Sam/amount type filtering #5701
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
As with the other PRs, address non-deprecation warnings. |
| displayCurrencyCode: selectedCryptoCurrencyCode, | ||
| exchangeAmount: isMaxAmount ? { max: true } : userInput, | ||
| fiatCurrencyCode: selectedFiatCurrencyCode, | ||
| amountType: lastUsedInput, |
There was a problem hiding this comment.
If lastUsedInput remains 'crypto' while cryptoInputDisabled becomes true (fiat-only plugins), the UI disables crypto input, but rampQuoteRequest still uses amountType: 'crypto'. That can trigger quote fetches with an unsupported amountType. Vice versa for fiat.
Suggestion: when computed disabled flags change, coerce lastUsedInput to a supported type (and optionally clear/convert userInput) so rampQuoteRequest always matches availability. Minimal guard alternative: do not build rampQuoteRequest if lastUsedInput corresponds to a disabled type.
| disabled={cryptoInputDisabled} | ||
| /> | ||
| {/* MAX Button */} | ||
| <MaxButton active={isMaxAmount} onPress={handleMaxPress}> |
There was a problem hiding this comment.
I recommend suggesting either guarding rampQuoteRequest when the selected
lastUsedInput is disabled, or auto-switching lastUsedInput to a supported type.
Or just disable this button when cryptoInputDisabled is true
This is an attempt to get the agent to automatically document lessons learned to the docs/ directory. This way conventions are maintained and over time as the agent is course corrected.
- Create docs/localization-guidelines.md with mandatory UI string localization rules - Create docs/component-styling-guidelines.md with styled HOC usage patterns - Update AGENTS.md with Documentation section indexing all docs/ files - Add rule requiring all docs/ markdown files to be indexed in AGENTS.md - Add localized strings for TradeRegionSelectScene to en_US.ts
This file contains run configuration such as RN_SIMULATOR and RN_PORT to be used by a rn-ios script. This is for development purposes
This is a consistent card design for the new fiat buy UI.
- Implement TradeCreateScene and TradeOptionSelectScene for buy/sell flow - Add Paybis as first ramp plugin with full API integration - Create reusable hooks for ramp plugin management (useRampPlugins, useRampQuotes) - Add payment type icon system with comprehensive mappings - Implement quote fetching and comparison across multiple providers - Add best rate badge component for quote comparison - Create ramp plugin type definitions and store utilities - Add comprehensive documentation for migration and architecture - Include unit tests for payment types and store IDs - Update navigation and deeplink handlers for ramp flows BREAKING CHANGE: Replaces legacy FiatPluginUi with new ramp plugin system
Include plugin IDs in React Query key so quotes refetch when region/currency/wallet changes affect available plugins. Simplify queryFn to always check current plugins while reusing valid cached quotes.
samholmes
force-pushed
the
sam/amount-type-filtering
branch
from
2e697a4 to
c00b32f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Replaced by #5740 |
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: